refactor: optimize zksync chain detection and add Creator Testnet test #4883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 454f063 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
==========================================
+ Coverage 47.59% 47.60% +0.01%
==========================================
Files 1054 1054
Lines 57144 57164 +20
Branches 3914 3917 +3
==========================================
+ Hits 27196 27212 +16
- Misses 29260 29263 +3
- Partials 688 689 +1
*This pull request uses carry forward flags. Click here to find out more.
|
jnsdls
requested changes
Oct 2, 2024
jnsdls
approved these changes
Oct 2, 2024
jnsdls
force-pushed
the
refactor_optimize_zksync_chain_detection_and_add_Creator_Testnet_test
branch
from
b99cdec to
9817aad
Compare
Contributor
Merge activity
|
#4883) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring code related to the handling of contract metadata, specifically around bytecode fetching and the integration of `zksync` support. It enhances the clarity and functionality of contract deployment processes. ### Detailed summary - Removed checks for `compilerType` in multiple files. - Simplified bytecode fetching by introducing `fetchBytecodeFromCompilerMetadata`. - Updated contract metadata handling in `fetchDeployMetadata`. - Adjusted UI components to reflect new metadata structure. - Added a test for sending transactions on the Creator Testnet. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
refactor_optimize_zksync_chain_detection_and_add_Creator_Testnet_test
branch
from
9817aad to
454f063
Compare
graphite-app
bot
deleted the
refactor_optimize_zksync_chain_detection_and_add_Creator_Testnet_test
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the handling of bytecode in the
thirdweblibrary, particularly forzksyncchains, and refactoring related functionalities for better clarity and performance.Detailed summary
publishedMetadatain favor of direct access todescriptionandlogo.fetchBytecodeFromCompilerMetadatafor better bytecode retrieval.SmartWalletto include a new transaction test.isZkSyncChainlogic for clarity.